Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add task solution #5094

Closed
wants to merge 1 commit into from
Closed

add task solution #5094

wants to merge 1 commit into from

Conversation

khorets
Copy link

@khorets khorets commented Dec 22, 2024

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your hard work! 😊 There are a few critical issues that need to be addressed before we can approve the PR. Specifically, the task requires separating the BEM blocks card and stars into their own SCSS files, and SCSS variables should be placed in a separate file. Additionally, the image path in index.html needs to be corrected to match the required format. Please address these points to fully meet the task requirements. Once these changes are made, your implementation will be in great shape! Keep up the great work! 🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.

@khorets khorets closed this Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants